Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12526 )
Change subject: [minicluster] Fix building with python 2.6 ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/12526/1/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py File build-support/mini-cluster/relocate_binaries_for_mini_cluster.py: http://gerrit.cloudera.org:8080/#/c/12526/1/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py@119 PS1, Line 119: check_output > We import check_output from kudu_util above which is python 2.6 compatible. To add more color: 1. subprocess.check_output is new in Python 2.7. 2. kudu_util.check_output is a carbon copy of Python 2.7's subprocess.check_output. 3. This script already imported kudu_util.check_output to use in one place, but didn't use it here, which is why the script stopped working on Python 2.6. -- To view, visit http://gerrit.cloudera.org:8080/12526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9e7ce9a1fd7ac813866678d6ec804fdf91ea729 Gerrit-Change-Number: 12526 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 19 Feb 2019 22:18:27 +0000 Gerrit-HasComments: Yes
