Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12538 )
Change subject: KUDU-2704: Rowsets that are much bigger than the target size discourage compactions ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/12538/1/src/kudu/tablet/compaction_policy-test.cc File src/kudu/tablet/compaction_policy-test.cc: http://gerrit.cloudera.org:8080/#/c/12538/1/src/kudu/tablet/compaction_policy-test.cc@630 PS1, Line 630: ASSERT_EQ(2, picked.size()); : ASSERT_GT(quality, 0.0); For my own understanding, without the patch, would the test case pick none, since the negative size score pushed them below the threshold? -- To view, visit http://gerrit.cloudera.org:8080/12538 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1771cd3dbbb17c87160a4bc38b48b3fbc7307676 Gerrit-Change-Number: 12538 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 20 Feb 2019 21:19:04 +0000 Gerrit-HasComments: Yes
