Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12538 )
Change subject: KUDU-2704: Rowsets that are much bigger than the target size discourage compactions ...................................................................... Patch Set 2: (1 comment) It seems it's too late, but those were just nits anyways. http://gerrit.cloudera.org:8080/#/c/12538/1/src/kudu/tablet/compaction_policy-test.cc File src/kudu/tablet/compaction_policy-test.cc: http://gerrit.cloudera.org:8080/#/c/12538/1/src/kudu/tablet/compaction_policy-test.cc@608 PS1, Line 608: double quality = 0.0; paranoid nit: maybe, set it to -1 because there is an assertion below that compares the value of this variable to 0, and the code below assumes the variable is set by RunTestCase(). Also, consider moving both 'quality' and 'picked' to the site of their usage. -- To view, visit http://gerrit.cloudera.org:8080/12538 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1771cd3dbbb17c87160a4bc38b48b3fbc7307676 Gerrit-Change-Number: 12538 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 20 Feb 2019 22:32:40 +0000 Gerrit-HasComments: Yes
