Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12523 )
Change subject: [test] Use the kudu binary in the external mini cluster ...................................................................... Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/12523/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12523/4//COMMIT_MSG@7 PS4, Line 7: [test] Use the kudu binary in the external mini cluster > I think you could also change dist_test.py to ship just the 'kudu' binary r Done http://gerrit.cloudera.org:8080/#/c/12523/4//COMMIT_MSG@9 PS4, Line 9: externa > external Done http://gerrit.cloudera.org:8080/#/c/12523/4//COMMIT_MSG@10 PS4, Line 10: it’s > its Done http://gerrit.cloudera.org:8080/#/c/12523/4/src/kudu/mini-cluster/external_mini_cluster.cc File src/kudu/mini-cluster/external_mini_cluster.cc: PS4: > It's unfortunate that JAR files (i.e. ZIP archives) don't allow symlinks; o I actually think I prefer the tooling style approach taken in the parent patch to the symlink style approach. We get some really nice help/usage output now that we didn't get before. And from a UX perspective a single binary is pretty nice. http://gerrit.cloudera.org:8080/#/c/12523/4/src/kudu/mini-cluster/external_mini_cluster.cc@1358 PS4, Line 1358: Status ExternalTabletServer::Start() { > Could you set up log_filename correctly here and for ExternalMaster::Start I think this happens by default now with all the logging fixes in my parent patch. http://gerrit.cloudera.org:8080/#/c/12523/4/src/kudu/tserver/tablet_server_main.cc File src/kudu/tserver/tablet_server_main.cc: PS4: > If you parameterize and reuse the TabletServerMain function as I suggested Done -- To view, visit http://gerrit.cloudera.org:8080/12523 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie963f5d50571f3d5ce55e40fcded245bf29b1b55 Gerrit-Change-Number: 12523 Gerrit-PatchSet: 5 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 21 Feb 2019 03:56:12 +0000 Gerrit-HasComments: Yes
