Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12523 )
Change subject: [test] Use the kudu binary in the external mini cluster ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/12523/8/src/kudu/integration-tests/security-faults-itest.cc File src/kudu/integration-tests/security-faults-itest.cc: PS8: > Not understanding why these changes are still necessary; aren't the logging I keep the logging file name and file details as kudu-master and kudu-tserver, but I do not change argv[0]. I think that makes the most sense. Hiding the fact that kudu is actually the binary run (or any other symlink/copy) seams bad and lossy to me. -- To view, visit http://gerrit.cloudera.org:8080/12523 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie963f5d50571f3d5ce55e40fcded245bf29b1b55 Gerrit-Change-Number: 12523 Gerrit-PatchSet: 8 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 21 Feb 2019 21:06:09 +0000 Gerrit-HasComments: Yes
