Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12545 )
Change subject: KUDU-2706: Workaround the lack of thread safety in krb5_parse_name() ...................................................................... Patch Set 1: (1 comment) > (2 comments) > > I just found https://github.com/krb5/krb5/blob/master/doc/threads.txt > which actually says that krb5_context isn't meant to be used by > multiple threads at a time. I'm OK fixing this with the workaround > here but maybe we should actually add a TODO? It seems we might be > playing a bit fast and loose and relying on some coincidences here. +1 Maybe, using krb5_copy_context() might help in some cases. Anyway, I think it's worth adding a TODO note that krb5_context is not meant for multi-thread usage. http://gerrit.cloudera.org:8080/#/c/12545/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12545/1//COMMIT_MSG@20 PS1, Line 20: leading to crashes (e.g. double free) or errors BTW, krb5_set_error_message() is also not thread safe. However, if you are sure the crash that you saw is addressed by this workaround, that's great. -- To view, visit http://gerrit.cloudera.org:8080/12545 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1bf9224516e2996f51f319088179727f76741ebe Gerrit-Change-Number: 12545 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 21 Feb 2019 18:30:54 +0000 Gerrit-HasComments: Yes
