Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12545 )
Change subject: KUDU-2706: Workaround the lack of thread safety in krb5_parse_name() ...................................................................... Patch Set 1: (2 comments) I just found https://github.com/krb5/krb5/blob/master/doc/threads.txt which actually says that krb5_context isn't meant to be used by multiple threads at a time. I'm OK fixing this with the workaround here but maybe we should actually add a TODO? It seems we might be playing a bit fast and loose and relying on some coincidences here. http://gerrit.cloudera.org:8080/#/c/12545/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12545/1//COMMIT_MSG@17 PS1, Line 17: In addition, krb5_parse_name() is also not thread safe I think it's clearer to explain that krb5_parse_name isn't thread-safe because the above lazy initialization is done with no locking. Aside from that, krb5_parse_name should be perfectly safe. http://gerrit.cloudera.org:8080/#/c/12545/1//COMMIT_MSG@22 PS1, Line 22: explicitly it's not really explicit -- you're implicitly initializing it by forcing krb5 to go through the lazy initialization path -- To view, visit http://gerrit.cloudera.org:8080/12545 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1bf9224516e2996f51f319088179727f76741ebe Gerrit-Change-Number: 12545 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 21 Feb 2019 18:15:54 +0000 Gerrit-HasComments: Yes
