Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12564 )
Change subject: [tests] address flake in TestClusterWithLocation ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12564/1/src/kudu/tools/ksck_remote-test.cc File src/kudu/tools/ksck_remote-test.cc: http://gerrit.cloudera.org:8080/#/c/12564/1/src/kudu/tools/ksck_remote-test.cc@526 PS1, Line 526: ASSERT_EVENTUALLY([&]() { > Curious why you chose to separate these four calls into two ASSERT_EVENTUAL Well, I started with wrapping only master-related calls, but I found that an extra flakiness exists also for the second pair of calls. Separating them helps since that way it's more time for recovery in total. I agree the most consistent way is to have one ASSERT_EVENTUALLY per call -- I'll update this. -- To view, visit http://gerrit.cloudera.org:8080/12564 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If74b9ade156a5007368112a213a1db4cba58cffe Gerrit-Change-Number: 12564 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 25 Feb 2019 20:10:47 +0000 Gerrit-HasComments: Yes
