Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12564 )
Change subject: [tests] address flake in TestClusterWithLocation ...................................................................... [tests] address flake in TestClusterWithLocation In case of TSAN builds and running the test at inferior machines with lot of concurrent activity, the masters and tablet servers run re-elections time to time. Until KUDU-2704 is addressed, ksck treats the state of a tablet captured during its Raft election process as problematic. Also, other related calls might timeout because of the slowness while simply establishing a connection. To avoid flakiness of this test because of that natural lifecycle events of Raft cluster, a few related calls are wrapped into ASSERT_EVENTUALLY() macro. In addition, introduced using strings::Substitute for better readability (non-functional update). Change-Id: If74b9ade156a5007368112a213a1db4cba58cffe Reviewed-on: http://gerrit.cloudera.org:8080/12564 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/tools/ksck_remote-test.cc 1 file changed, 50 insertions(+), 34 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/12564 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If74b9ade156a5007368112a213a1db4cba58cffe Gerrit-Change-Number: 12564 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
