Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12605
to review the following change.
Change subject: schema: Fix ColumnSchema::Equals() usage
......................................................................
schema: Fix ColumnSchema::Equals() usage
In commit 4be39feef4907550c16f9d2b34430d098b9f1b21 the signature of
ColumnSchema::Equals() was changed from taking a boolean flag for
checking whether the defaults matched to taking an enum for describing a
broader set of comparison options. However, a few call sites were not
updated when that change was made, and due to type coercion several call
sites ended up with weaker comparison semantics.
This patch reinstates the behavior prior to the merge of the
above-mentioned patch for the problematic call sites and updates the
function signature of ColumnSchema::Equals() to treat the comparison
enum as strongly typed to avoid similar problems in the future.
Updated tests to add coverage for the relevant call sites.
Change-Id: I416e4a44d0ed259d251d52a663b72acd79b46f33
---
M src/kudu/client/client-unittest.cc
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/common/column_predicate-test.cc
M src/kudu/common/column_predicate.cc
M src/kudu/common/column_predicate.h
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.h
8 files changed, 84 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/12605/1
--
To view, visit http://gerrit.cloudera.org:8080/12605
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I416e4a44d0ed259d251d52a663b72acd79b46f33
Gerrit-Change-Number: 12605
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
