Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12605 )
Change subject: schema: Fix ColumnSchema::Equals() usage ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12605/1/src/kudu/common/column_predicate-test.cc File src/kudu/common/column_predicate-test.cc: http://gerrit.cloudera.org:8080/#/c/12605/1/src/kudu/common/column_predicate-test.cc@1470 PS1, Line 1470: using TestColumnPredicateDeathTest = TestColumnPredicate; > What's the purpose of this aliasing? That works as well as defining a new class with DeathTest in the name, which is recommended by the gtest documentation at https://github.com/google/googletest/blob/master/googletest/docs/advanced.md#death-test-naming so that the framework can place additional thread safety related safeguards in place. -- To view, visit http://gerrit.cloudera.org:8080/12605 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I416e4a44d0ed259d251d52a663b72acd79b46f33 Gerrit-Change-Number: 12605 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Tue, 26 Feb 2019 23:53:51 +0000 Gerrit-HasComments: Yes
