Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/12602 )
Change subject: [docker] Fix build script to work outside of Git WD ...................................................................... Patch Set 1: (1 comment) > Patch Set 1: > > (1 comment) > > I am curious about the motivation. I downloaded the RC1 from dist.a.o and tried to build it from there and it failed. I believe it should be possible to build from the published releases, not only from the Git working directory. http://gerrit.cloudera.org:8080/#/c/12602/1/docker/docker-build.sh File docker/docker-build.sh: http://gerrit.cloudera.org:8080/#/c/12602/1/docker/docker-build.sh@222 PS1, Line 222: HASH_TAG_PATTERN="$REPOSITORY:*$VCS_REF*" > This change could be problematic here. You're right. What if I add "$VCS_REF" != "$VERSION" to the condition? -- To view, visit http://gerrit.cloudera.org:8080/12602 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I802157687384f3fd1b223d26041b3e8e1722b965 Gerrit-Change-Number: 12602 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 27 Feb 2019 11:40:02 +0000 Gerrit-HasComments: Yes
