Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/12602 )
Change subject: [docker] Fix build to work outside of Git WD ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/12602/1/docker/docker-build.sh File docker/docker-build.sh: http://gerrit.cloudera.org:8080/#/c/12602/1/docker/docker-build.sh@108 PS1, Line 108: VCS_REF=$(git rev-parse --short HEAD || echo $VERSION) > Can we set VCS_REF to "" instead? Done http://gerrit.cloudera.org:8080/#/c/12602/1/docker/docker-build.sh@112 PS1, Line 112: IS_RELEASE_VERSION=0 > I think we can add a check here and if VCS_REF == "" echo an error saying t Done http://gerrit.cloudera.org:8080/#/c/12602/1/docker/docker-build.sh@222 PS1, Line 222: HASH_TAG_PATTERN="$REPOSITORY:*$VCS_REF*" > Since this only happens in source releases, IS_RELEASE_VERSION will always Done -- To view, visit http://gerrit.cloudera.org:8080/12602 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I802157687384f3fd1b223d26041b3e8e1722b965 Gerrit-Change-Number: 12602 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 27 Feb 2019 17:50:08 +0000 Gerrit-HasComments: Yes
