Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12618 )
Change subject: tools: make it easier to scan full rows with 'kudu table scan' ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12618/1/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/12618/1/src/kudu/tools/table_scanner.cc@344 PS1, Line 344: bool project_all = FLAGS_columns == "*" || > I was ever want to add this logic code, but how to deal the case when a col I thought about this a bit. We could remove the '*' option but I thought it was unlikely that someone would name a column '*', and this is just a CLI tool. It would still be possible to access such a column from a real API. What do others think about this? -- To view, visit http://gerrit.cloudera.org:8080/12618 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89f017baeb0153992ffa0a40b4996a5eb50330f6 Gerrit-Change-Number: 12618 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 27 Feb 2019 17:50:33 +0000 Gerrit-HasComments: Yes
