Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12563 )
Change subject: [tools] Add tool to copy table data to another table ...................................................................... Patch Set 1: (3 comments) Just passing through with a few questions. http://gerrit.cloudera.org:8080/#/c/12563/1/src/kudu/common/partition.h File src/kudu/common/partition.h: http://gerrit.cloudera.org:8080/#/c/12563/1/src/kudu/common/partition.h@139 PS1, Line 139: struct RangeSchema { : std::vector<ColumnId> column_ids; : }; Does this need to be public? http://gerrit.cloudera.org:8080/#/c/12563/1/src/kudu/common/schema.h File src/kudu/common/schema.h: http://gerrit.cloudera.org:8080/#/c/12563/1/src/kudu/common/schema.h@899 PS1, Line 899: void ToUserSchema() { Is this necessary? Couldn't you get by with CopyWithoutColumnIds(), which continues to treat the Schema as immutable and returns a copy? http://gerrit.cloudera.org:8080/#/c/12563/1/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/12563/1/src/kudu/tools/table_scanner.cc@335 PS1, Line 335: dst_table_schema.ToUserKuduSchema(); Curious as to whether we could instead remove column IDs from client schemas, either at the time that we receive them from the server (i.e. processing a GetTableSchemaResponse), at the time that the server sends back schemas (i.e. responding to a GetTableSchema RPC), or both. Then we could transparently feed the schema a client receives into something like CreateTable. Would that work? Or does the client need column IDs for something? -- To view, visit http://gerrit.cloudera.org:8080/12563 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifdec51701ac9ec57739b1a6f7c18786294642a54 Gerrit-Change-Number: 12563 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 27 Feb 2019 17:59:38 +0000 Gerrit-HasComments: Yes
