Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12563 )
Change subject: [tools] Add tool to copy table data to another table ...................................................................... Patch Set 7: (3 comments) Nice refactoring. http://gerrit.cloudera.org:8080/#/c/12563/7/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/12563/7/src/kudu/tools/kudu-tool-test.cc@2861 PS7, Line 2861: TEST_F(ToolTest, TestCopyTableSchemaOnly) { There's a lot of repetition between these tests. Consider making them parameterized on TableCopyMode. Search for TEST_P in this file to see how this is done. http://gerrit.cloudera.org:8080/#/c/12563/5/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/12563/5/src/kudu/tools/table_scanner.cc@321 PS5, Line 321: > Done Whoops, I made a typo in my recommendation. Should have been "Destination table is the same as the source table". Sorry! http://gerrit.cloudera.org:8080/#/c/12563/7/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/12563/7/src/kudu/tools/table_scanner.cc@20 PS7, Line 20: #include <stddef.h> : #include <stdint.h> : #include <string.h> Nit: we prefer C++ equivalents where they exist (i.e. <cstddef>, <cstdint>, and <cstring>). -- To view, visit http://gerrit.cloudera.org:8080/12563 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifdec51701ac9ec57739b1a6f7c18786294642a54 Gerrit-Change-Number: 12563 Gerrit-PatchSet: 7 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 21 Mar 2019 18:58:11 +0000 Gerrit-HasComments: Yes
