Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12619 )
Change subject: [master] cache assigned locations ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12619/3/src/kudu/master/ts_manager.h File src/kudu/master/ts_manager.h: http://gerrit.cloudera.org:8080/#/c/12619/3/src/kudu/master/ts_manager.h@52 PS3, Line 52: TSManager(LocationCache* location_cache, Should add a comment here about how the location cache must outlive the TSManager. -- To view, visit http://gerrit.cloudera.org:8080/12619 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12c8952c43a8ad352acd46c8006824b2ad9d1204 Gerrit-Change-Number: 12619 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 28 Feb 2019 02:30:08 +0000 Gerrit-HasComments: Yes
