Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12619 )
Change subject: [master] use cache for assigned locations ...................................................................... Patch Set 7: Code-Review+2 (1 comment) There's some spots in the test where I think they could be flaky but it may be so unlikely we never actually see it, so I am OK with committing this and dealing with flakiness if it occurs. http://gerrit.cloudera.org:8080/#/c/12619/7/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/12619/7/src/kudu/client/client-test.cc@6019 PS7, Line 6019: ASSERT_EQ(queries_before + kIterNum, queries_after); I think there is a very small chance for flakiness here. If the connect to cluster is retried because of some leadership blip in the masters, there could be more than queries_before + kIterNum queries. -- To view, visit http://gerrit.cloudera.org:8080/12619 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12c8952c43a8ad352acd46c8006824b2ad9d1204 Gerrit-Change-Number: 12619 Gerrit-PatchSet: 7 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 28 Feb 2019 18:48:46 +0000 Gerrit-HasComments: Yes
