Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12634 )
Change subject: [master] introduce cache for location mapping assignments ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Will should review this too. http://gerrit.cloudera.org:8080/#/c/12634/1/src/kudu/master/location_cache-test.cc File src/kudu/master/location_cache-test.cc: http://gerrit.cloudera.org:8080/#/c/12634/1/src/kudu/master/location_cache-test.cc@172 PS1, Line 172: : { : vector<thread> threads; : threads.reserve(kNumThreads); : for (auto idx = 0; idx < kNumThreads; ++idx) { : threads.emplace_back([&cache, &kRefLocation, idx]() { : string location; : auto s = cache.GetLocation(Substitute("key_$0", idx), &location); : CHECK(s.ok()) << s.ToString(); : CHECK_EQ(kRefLocation, location); : }); : } : for (auto& t : threads) { : t.join(); : } : } This is duplicated from above; consider using a for loop to just run it twice, checking the metrics in a slightly different way each time. -- To view, visit http://gerrit.cloudera.org:8080/12634 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb5c436c9433acd87c44c4d81982420f33ebb4a4 Gerrit-Change-Number: 12634 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 28 Feb 2019 06:17:21 +0000 Gerrit-HasComments: Yes
