Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12634 )
Change subject: [master] introduce cache for location mapping assignments ...................................................................... Patch Set 1: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/12634/1/src/kudu/master/location_cache.h File src/kudu/master/location_cache.h: http://gerrit.cloudera.org:8080/#/c/12634/1/src/kudu/master/location_cache.h@31 PS1, Line 31: // Get the location for the specified key. nit: describe the cache and its properties? Unlimited size, never invalidated, etc. http://gerrit.cloudera.org:8080/#/c/12634/1/src/kudu/master/location_cache.h@43 PS1, Line 43: 'cmd'. Might be missing something, but why not use location_mapping_cmd_? http://gerrit.cloudera.org:8080/#/c/12634/1/src/kudu/master/location_cache.h@64 PS1, Line 64: queries_ nit: maybe call this location_mapping_cache_misses_ then? -- To view, visit http://gerrit.cloudera.org:8080/12634 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb5c436c9433acd87c44c4d81982420f33ebb4a4 Gerrit-Change-Number: 12634 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 28 Feb 2019 08:09:34 +0000 Gerrit-HasComments: Yes
