Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12643 )
Change subject: [thirdparty] Bump RapidJSON version to 1.1.0 ...................................................................... Patch Set 5: (2 comments) > (1 comment) > > looks like lots of test failures from this new version in ASAN > builds. I think Mike and Adar have been looking at rapidjson UBSAN > problems as well thanks! http://gerrit.cloudera.org:8080/#/c/12643/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12643/5//COMMIT_MSG@16 PS5, Line 16: output multiple JSONs, and also add an unit test for this. > what's the advantage of reset vs a new one? it can reuse a buffer or someth Yes, and an unit test TestTablet.TestMetricsInit in src/kudu/tablet/tablet-test.cc will fail if not reset. The new added function Reset() in rapidJSON could be exposed to the wrapper to deal with these problems. http://gerrit.cloudera.org:8080/#/c/12643/3/src/kudu/tablet/tablet-test.cc File src/kudu/tablet/tablet-test.cc: http://gerrit.cloudera.org:8080/#/c/12643/3/src/kudu/tablet/tablet-test.cc@1112 PS3, Line 1112: writer.Reset(); An core will occur in rapidJSON if not Reset(). On rapidjson/writer.h:452 RAPIDJSON_ASSERT(!hasRoot_); -- To view, visit http://gerrit.cloudera.org:8080/12643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c5e6bf6b8c6802bde28716487abb2b242a7a578 Gerrit-Change-Number: 12643 Gerrit-PatchSet: 5 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sun, 03 Mar 2019 03:10:03 +0000 Gerrit-HasComments: Yes
