Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12643 )
Change subject: [thirdparty] Bump RapidJSON version to 1.1.0 ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/12643/6/src/kudu/tablet/tablet-test.cc File src/kudu/tablet/tablet-test.cc: http://gerrit.cloudera.org:8080/#/c/12643/6/src/kudu/tablet/tablet-test.cc@1114 PS6, Line 1114: { > Nit: lift this out of the new scope; it doesn't need to be in there. Done http://gerrit.cloudera.org:8080/#/c/12643/5/src/kudu/util/jsonwriter.cc File src/kudu/util/jsonwriter.cc: http://gerrit.cloudera.org:8080/#/c/12643/5/src/kudu/util/jsonwriter.cc@30 PS5, Line 30: // IWYU pragma: no_include <rapidjson/internal/../rapidjson.h> > Like this: I have to add both no_include and keep pragmas to mute this warnning, like: // IWYU pragma: no_include <rapidjson/internal/../rapidjson.h> #include <rapidjson/prettywriter.h> #include <rapidjson/rapidjson.h> // IWYU pragma: keep -- To view, visit http://gerrit.cloudera.org:8080/12643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c5e6bf6b8c6802bde28716487abb2b242a7a578 Gerrit-Change-Number: 12643 Gerrit-PatchSet: 7 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 06 Mar 2019 15:31:14 +0000 Gerrit-HasComments: Yes
