Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12653 )
Change subject: WIP [master] introduced SentryAuthzCache ...................................................................... Patch Set 1: (2 comments) Rough, high-level pass since this is still a WIP. http://gerrit.cloudera.org:8080/#/c/12653/1/src/kudu/master/sentry_authz_cache.h File src/kudu/master/sentry_authz_cache.h: http://gerrit.cloudera.org:8080/#/c/12653/1/src/kudu/master/sentry_authz_cache.h@26 PS1, Line 26: /* : #include <gflags/gflags.h> : #include <gflags/gflags_declare.h> : */ Remove these. http://gerrit.cloudera.org:8080/#/c/12653/1/src/kudu/master/sentry_authz_cache.h@50 PS1, Line 50: SentryAuthzCache The API this exposes isn't very cache-like (e.g. no Put), so it probably deserves a different name (though I haven't come up with a good one. Maybe SentryPrivilegeGetter or something?). Alternatively, I wonder if this can be put directly in the SentryAuthzProvider? Unless you foresee it sprouting new functionality that makes encapsulating it useful (e.g. the batching up of requests to Sentry). -- To view, visit http://gerrit.cloudera.org:8080/12653 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If377cd4a7bae481ffc9a6950cb26862b66e9bab5 Gerrit-Change-Number: 12653 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 05 Mar 2019 08:27:03 +0000 Gerrit-HasComments: Yes
