Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12653 )
Change subject: WIP [master] introduced SentryAuthzCache ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12653/1/src/kudu/master/sentry_authz_provider.cc File src/kudu/master/sentry_authz_provider.cc: http://gerrit.cloudera.org:8080/#/c/12653/1/src/kudu/master/sentry_authz_provider.cc@319 PS1, Line 319: if (PREDICT_TRUE(cache_)) { > If I am reading this correctly, when cache is enabled and a privilege is no Nope, that's not the case. When cache is enabled and the information is not in the cache, the required information will be fetched from the authz provider. The entries in the cache are replaced when the cache is at capacity -- that's how caches are works usually. -- To view, visit http://gerrit.cloudera.org:8080/12653 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If377cd4a7bae481ffc9a6950cb26862b66e9bab5 Gerrit-Change-Number: 12653 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 19 Mar 2019 00:04:23 +0000 Gerrit-HasComments: Yes
