Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12647 )
Change subject: [TS heartbeater] avoid reconnecting to master too often ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/12647/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12647/1//COMMIT_MSG@9 PS1, Line 9: don't "won't" or "doesn't" http://gerrit.cloudera.org:8080/#/c/12647/1//COMMIT_MSG@11 PS1, Line 11: is accepting connections and Ping RPC : requests but isn't able to properly respond to TS heartbeats Looking at the code, why does this situation return a NetworkError? Shouldn't it be a ServiceUnavailable error? http://gerrit.cloudera.org:8080/#/c/12647/1/src/kudu/tserver/heartbeater.cc File src/kudu/tserver/heartbeater.cc: http://gerrit.cloudera.org:8080/#/c/12647/1/src/kudu/tserver/heartbeater.cc@595 PS1, Line 595: * At least once per (heartbeat_rpc_timeout ^ 2 / heartbeat_interval) : // time interval; the worst case is when every HB request times out. Where does this factor in? What's the idea behind this formula? I don't get it. http://gerrit.cloudera.org:8080/#/c/12647/1/src/kudu/tserver/heartbeater.cc@597 PS1, Line 597: (heartbeat_rpc_timeout / heartbeat_interval) : // time interval This isn't a timeout-- it's a unitless quantity, the number of heartbeats expected per timeout interval. What you are saying in the code is that at least the expected number of heartbeats that would happen in one timeout interval should fail consecutively before resetting the proxy. http://gerrit.cloudera.org:8080/#/c/12647/1/src/kudu/tserver/heartbeater.cc@607 PS1, Line 607: consecutive_failed_heartbeats_ % : num_consecutive_failures_proxy_reset == 0 Could you split the line so each condition goes on a separate line? -- To view, visit http://gerrit.cloudera.org:8080/12647 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I961ae453ffd6ce343574ce58cb0e13fdad218078 Gerrit-Change-Number: 12647 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 05 Mar 2019 17:46:43 +0000 Gerrit-HasComments: Yes
