Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12647 )
Change subject: [TS heartbeater] avoid reconnecting to master too often ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/12647/1/src/kudu/tserver/heartbeater.cc File src/kudu/tserver/heartbeater.cc: http://gerrit.cloudera.org:8080/#/c/12647/1/src/kudu/tserver/heartbeater.cc@592 PS1, Line 592: Pretty arbitrary number to determine Can you reword this? "Pretty arbitrary" makes this sound like not a whole lot of thought was put into this. http://gerrit.cloudera.org:8080/#/c/12647/1/src/kudu/tserver/heartbeater.cc@600 PS1, Line 600: num_consecutive_failures_proxy_reset Would be nice to describe what this variable is. Something like "the period, in number of failures, that dictates the frequency at which we will reset the proxy" or something? http://gerrit.cloudera.org:8080/#/c/12647/1/src/kudu/tserver/heartbeater.cc@607 PS1, Line 607: s.IsNetworkError() How did you test this? I thought I saw cases where this actually was a network error. -- To view, visit http://gerrit.cloudera.org:8080/12647 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I961ae453ffd6ce343574ce58cb0e13fdad218078 Gerrit-Change-Number: 12647 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 05 Mar 2019 18:35:07 +0000 Gerrit-HasComments: Yes
