Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12661 )
Change subject: tserver: remove DEPRECATED_range_predicates ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12661/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12661/2//COMMIT_MSG@9 PS2, Line 9: This field hasn't been touched in 3 years (Kudu 0.8.0), and would : otherwise be another piece of a scan to consider for authorization. : Before moving ahead with authorization, it seems like as good a time as : any to remove it. Using this field will now result in an error being : returned to clients. > I agree that ColumnRangePredicates have been deprecated for a long time, bu This wouldn't make it "more complex" per se, but if we don't remove this, I will need to write code to handle the field, which feels odd given it's deprecated status. Three years seems like a long enough sunset period to give users time to move off of it. Otherwise, what's the point of labeling it deprecated in the first place? -- To view, visit http://gerrit.cloudera.org:8080/12661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e338974e81321660652dd3b866efc0c9a865566 Gerrit-Change-Number: 12661 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 05 Mar 2019 23:22:05 +0000 Gerrit-HasComments: Yes
