Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12661 )
Change subject: tserver: remove DEPRECATED_range_predicates ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12661/1/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/12661/1/src/kudu/tserver/tablet_service.cc@a1872 PS1, Line 1872: Can we somehow enforce that the client is new enough to not be sending these? I'm fine breaking kudu 0.8 client, but we should make sure that if someone uses it, it gets back a nice error message rather than silently ignoring the passed predicates. One option is to do something like: if (scan_pb.deprecated_range_predicates_size() > 0) { return Status::InvalidArgument("Kudu client version 0.8 and older not supported"); } -- To view, visit http://gerrit.cloudera.org:8080/12661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e338974e81321660652dd3b866efc0c9a865566 Gerrit-Change-Number: 12661 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 05 Mar 2019 17:43:18 +0000 Gerrit-HasComments: Yes
