Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12468 )
Change subject: KUDU-2514 Support extra config for table. ...................................................................... Patch Set 2: (2 comments) Hi, adar. Thanks for review. http://gerrit.cloudera.org:8080/#/c/12468/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12468/2//COMMIT_MSG@11 PS2, Line 11: Now, we can specify the history max age second of the table by this feature. > Could you split this out into a separate patch? It'd be easier to review th I will split this out into a separate patch. http://gerrit.cloudera.org:8080/#/c/12468/2/java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java File java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java: http://gerrit.cloudera.org:8080/#/c/12468/2/java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java@364 PS2, Line 364: public AlterTableOptions alterHistoryMaxAgeSec(int historyMaxAgeSec) { > A related question is, if we're going to do this via a more generic key/val Your advice is very reasonable. I got it. I think it's better to provide a fixed set of keys. -- To view, visit http://gerrit.cloudera.org:8080/12468 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0514507dca95602a97e954d1db464b907e073aae Gerrit-Change-Number: 12468 Gerrit-PatchSet: 2 Gerrit-Owner: Yao Xu <ocla...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Yao Xu <ocla...@gmail.com> Gerrit-Comment-Date: Wed, 06 Mar 2019 03:09:23 +0000 Gerrit-HasComments: Yes
