Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12468 )
Change subject: KUDU-2514 Support extra config for table. ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/12468/2/java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java File java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java: http://gerrit.cloudera.org:8080/#/c/12468/2/java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java@360 PS2, Line 360: tracing seems like this comment needs updating? http://gerrit.cloudera.org:8080/#/c/12468/2/java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java@364 PS2, Line 364: public AlterTableOptions alterHistoryMaxAgeSec(int historyMaxAgeSec) { I think it's worth a discussion whether we want to add a separate API for each config, or instead use more of a String/String or String/int key-value design in the API? The advantage of a "key/value" type thing is that generic tools like SQL could implement this without having to hard-code every new parameter as it becomes available. http://gerrit.cloudera.org:8080/#/c/12468/2/src/kudu/client/table_alterer-internal.h File src/kudu/client/table_alterer-internal.h: http://gerrit.cloudera.org:8080/#/c/12468/2/src/kudu/client/table_alterer-internal.h@68 PS2, Line 68: TableExtraConfigPB perhaps should be optional? http://gerrit.cloudera.org:8080/#/c/12468/2/src/kudu/master/master_path_handlers.cc File src/kudu/master/master_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/12468/2/src/kudu/master/master_path_handlers.cc@404 PS2, Line 404: DebugString should probably use SecureDebugString http://gerrit.cloudera.org:8080/#/c/12468/2/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/12468/2/src/kudu/tools/tool_action_table.cc@494 PS2, Line 494: ActionBuilder("set_history_max_age", &SetHistoryMaxAge) per comment elsewhere, worth considering whether this should just be more like a key/value string CLI -- To view, visit http://gerrit.cloudera.org:8080/12468 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0514507dca95602a97e954d1db464b907e073aae Gerrit-Change-Number: 12468 Gerrit-PatchSet: 2 Gerrit-Owner: Yao Xu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 27 Feb 2019 00:51:08 +0000 Gerrit-HasComments: Yes
