Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12735
to review the following change.
Change subject: KUDU-2741: De-flake TestMergeIterator.TestDeDupGhostRows
......................................................................
KUDU-2741: De-flake TestMergeIterator.TestDeDupGhostRows
This test had a couple of test-only bugs related to bookkeeping,
resulting in this test being flaky in certain scenarios. This patch
fixes those bugs:
1. Ensure that we don't generate duplicate keys in the same list (a.k.a.
RowSet) during the test because that can't occur "in the wild" and
the MergeIterator does not support it.
2. Ensure that we don't maintain more than one instance of a single
row key in the 'expected' result set. Switch to using an ordered map
to enforce that test invariant. An additional benefit to using that
data structure is that we can skip the sorting step when iterating
the expected results.
Before this change, the test had a failure rate of about 10% according
to the flaky test dashboard. After this change, the tests passes
reliably and succeeded 1024/1024 times when I looped it using dist-test:
http://dist-test.cloudera.org/job?job_id=mpercy.1552437266.46341
Change-Id: I5ca9cdfa4620b1a9d4144de2289cc80ac37060aa
---
M src/kudu/common/generic_iterators-test.cc
1 file changed, 59 insertions(+), 40 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/12735/1
--
To view, visit http://gerrit.cloudera.org:8080/12735
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ca9cdfa4620b1a9d4144de2289cc80ac37060aa
Gerrit-Change-Number: 12735
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
