Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12735 )

Change subject: KUDU-2741: De-flake TestMergeIterator.TestDeDupGhostRows
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12735/1/src/kudu/common/generic_iterators-test.cc
File src/kudu/common/generic_iterators-test.cc:

http://gerrit.cloudera.org:8080/#/c/12735/1/src/kudu/common/generic_iterators-test.cc@258
PS1, Line 258:   vector<List> all_ints;
Hmm, I thought defining a one-arg List constructor means the compiler won't 
generate a default constructor, in which case how is it possible to create a 
vector<List>?



--
To view, visit http://gerrit.cloudera.org:8080/12735
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ca9cdfa4620b1a9d4144de2289cc80ac37060aa
Gerrit-Change-Number: 12735
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 13 Mar 2019 04:19:08 +0000
Gerrit-HasComments: Yes

Reply via email to