Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12318 )

Change subject: KUDU-2411: Example integration test using KuduMiniCluster
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12318/5/examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java
File 
examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java:

http://gerrit.cloudera.org:8080/#/c/12318/5/examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java@30
PS5, Line 30:     public KuduTestHarness harness = new KuduTestHarness();
> I think for the purposes of an example you should vigorously and energetica
At a minimum, let's copy the comments from the documentation found here: 
https://kudu.apache.org/docs/developing.html#_using_the_kudu_binary_test_jar



--
To view, visit http://gerrit.cloudera.org:8080/12318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d
Gerrit-Change-Number: 12318
Gerrit-PatchSet: 7
Gerrit-Owner: Brian McDevitt <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Brian McDevitt <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Comment-Date: Wed, 13 Mar 2019 00:42:38 +0000
Gerrit-HasComments: Yes

Reply via email to