Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12749 )
Change subject: [TSManager] don't hold lock while running LA command ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12749/1/src/kudu/master/ts_manager.cc File src/kudu/master/ts_manager.cc: http://gerrit.cloudera.org:8080/#/c/12749/1/src/kudu/master/ts_manager.cc@143 PS1, Line 143: location.emplace(location_str); No std::move()? http://gerrit.cloudera.org:8080/#/c/12749/1/src/kudu/master/ts_manager.cc@150 PS1, Line 150: if (ContainsKey(servers_by_id_, uuid)) { : descriptor = FindOrDie(servers_by_id_, uuid); Should be able to use a Find* function to avoid the double lookup in the reregistration case. -- To view, visit http://gerrit.cloudera.org:8080/12749 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I59cd5f6ed19c162a7c9f9a6527e78cab782b4539 Gerrit-Change-Number: 12749 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 14 Mar 2019 00:41:37 +0000 Gerrit-HasComments: Yes
