Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12749 )
Change subject: [TSManager] don't hold lock while running LA command ...................................................................... [TSManager] don't hold lock while running LA command This patch modifies the way how the location assignment is run during the course of tablet server registration with master. Prior to this patch, TSManager's lock on the registry of all tablet servers was held while running the location assignment command. That might lead to stacking many TS registration heartbeats in flight while master's service threads are waiting to acquire the TSManager's lock. This patch introduces changes to run the location assignment command without holding the TSManager's lock. That makes the registration of tablet servers with masters more robust and makes the processing of concurrent heartbeats from tablet servers more efficient overall. Change-Id: I59cd5f6ed19c162a7c9f9a6527e78cab782b4539 Reviewed-on: http://gerrit.cloudera.org:8080/12749 Tested-by: Kudu Jenkins Reviewed-by: Will Berkeley <[email protected]> Reviewed-by: Adar Dembo <[email protected]> --- M src/kudu/master/location_cache-test.cc M src/kudu/master/master.cc M src/kudu/master/ts_descriptor-test.cc M src/kudu/master/ts_descriptor.cc M src/kudu/master/ts_descriptor.h M src/kudu/master/ts_manager.cc 6 files changed, 124 insertions(+), 143 deletions(-) Approvals: Kudu Jenkins: Verified Will Berkeley: Looks good to me, approved Adar Dembo: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/12749 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I59cd5f6ed19c162a7c9f9a6527e78cab782b4539 Gerrit-Change-Number: 12749 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley <[email protected]>
