Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12835 )
Change subject: [json] Add JsonFileReader to read JSON content from file ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12835/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12835/1//COMMIT_MSG@14 PS1, Line 14: With JsonFileReader, it's able to read configuration from file, and gflags natively supports "flags files" -- you can use --flagfile=/path/to/flags to load it. Is that sufficient for your use case? http://gerrit.cloudera.org:8080/#/c/12835/1//COMMIT_MSG@19 PS1, Line 19: name, which will be resolved to master rpc addresses by a JSON file. I think we should have a more general discussion about this direction. This has been a topic of debate in the past. Perhaps you can take over looking at https://issues.apache.org/jira/browse/KUDU-1948 ? The discussion there has a lot of good points brought up by Dan Burkert and others about some of the downsides of config files, so we should make sure we take them into account. Maybe we can discuss a proposal there, and then once everyone agrees on the direction, we can look at the implementation? -- To view, visit http://gerrit.cloudera.org:8080/12835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c57c3c31189578268b126ef535bf3f933867288 Gerrit-Change-Number: 12835 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 22 Mar 2019 18:54:00 +0000 Gerrit-HasComments: Yes
