Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11753 )
Change subject: authz: verify tokens on scans ...................................................................... Patch Set 13: (5 comments) http://gerrit.cloudera.org:8080/#/c/11753/12/src/kudu/tserver/tablet_server_authorization-test.cc File src/kudu/tserver/tablet_server_authorization-test.cc: http://gerrit.cloudera.org:8080/#/c/11753/12/src/kudu/tserver/tablet_server_authorization-test.cc@356 PS12, Line 356: > nit: extra period. Done http://gerrit.cloudera.org:8080/#/c/11753/12/src/kudu/tserver/tablet_server_authorization-test.cc@1027 PS12, Line 1027: TEST_P(ScanPrivilegeWithVirtualColumnsTest, TestIsDeletedColumn) { > nit: extra line. Done http://gerrit.cloudera.org:8080/#/c/11753/12/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/11753/12/src/kudu/tserver/tablet_service.cc@429 PS12, Line 429: incorrectly get a "not found" e > Can you add an example of how virtual columns can leak presence of columns Done in the commit message http://gerrit.cloudera.org:8080/#/c/11753/12/src/kudu/tserver/tablet_service.cc@1743 PS12, Line 1743: > nit: extra space. Done http://gerrit.cloudera.org:8080/#/c/11753/12/src/kudu/tserver/tablet_service.cc@1901 PS12, Line 1901: > nit: alignment? Done -- To view, visit http://gerrit.cloudera.org:8080/11753 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a5d81cf215a5d936f8853feba05778038764905 Gerrit-Change-Number: 11753 Gerrit-PatchSet: 13 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 22 Mar 2019 22:10:28 +0000 Gerrit-HasComments: Yes
