Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11753 )
Change subject: authz: verify tokens on scans ...................................................................... Patch Set 13: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/11753/13//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11753/13//COMMIT_MSG@50 PS13, Line 50: - In the latter case, in order to prevent leaking the existence (or Nit: good explanation; might want to reformat this list using numbered items since they're not so much part of the larger list. http://gerrit.cloudera.org:8080/#/c/11753/13//COMMIT_MSG@55 PS13, Line 55: expect it to Nit: a bit ambiguous; don't expect it to exist? Or don't expect it to have a virtual type? In context I know you mean the former, but it reads a little funny. -- To view, visit http://gerrit.cloudera.org:8080/11753 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a5d81cf215a5d936f8853feba05778038764905 Gerrit-Change-Number: 11753 Gerrit-PatchSet: 13 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sat, 23 Mar 2019 22:48:34 +0000 Gerrit-HasComments: Yes
