Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12842 )
Change subject: KUDU-2750: Add create and alter timestamp to tables ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/12842/1/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/12842/1/src/kudu/master/master.proto@185 PS1, Line 185: // The create time of the table. nit: add "in seconds since the epoch" http://gerrit.cloudera.org:8080/#/c/12842/1/src/kudu/master/master.proto@186 PS1, Line 186: optional int64 create_time = 10; nit: can you rename this and the below field to '_timestamp' instead of '_time'? Just to make it extra clear that it's a point in time and not a duration http://gerrit.cloudera.org:8080/#/c/12842/1/src/kudu/master/master.proto@187 PS1, Line 187: // The last alter time of the table. same http://gerrit.cloudera.org:8080/#/c/12842/1/src/kudu/master/master_path_handlers.cc File src/kudu/master/master_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/12842/1/src/kudu/master/master_path_handlers.cc@202 PS1, Line 202: strCreateTime style nit: str_create_time http://gerrit.cloudera.org:8080/#/c/12842/1/src/kudu/master/master_path_handlers.cc@207 PS1, Line 207: std::string strAlterTime; same -- To view, visit http://gerrit.cloudera.org:8080/12842 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife05719cea26b15fdf2b5667b60c3e89947cdda8 Gerrit-Change-Number: 12842 Gerrit-PatchSet: 1 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 25 Mar 2019 15:49:03 +0000 Gerrit-HasComments: Yes
