Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/12847 )
Change subject: [KUDU-1344] Part 1: cmake install for executables ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12847/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12847/1//COMMIT_MSG@18 PS1, Line 18: This change also adds 3 cmake flags (off by default): > instead of the "double negative" flags, can we add on-by-default flags whic Good point about double negative flags. -- To view, visit http://gerrit.cloudera.org:8080/12847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7 Gerrit-Change-Number: 12847 Gerrit-PatchSet: 1 Gerrit-Owner: Greg Solovyev <gsolov...@cloudera.com> Gerrit-Reviewer: Greg Solovyev <gsolov...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 25 Mar 2019 22:46:13 +0000 Gerrit-HasComments: Yes
