Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12847 )
Change subject: [KUDU-1344] Part 1: cmake install for executables ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12847/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12847/1//COMMIT_MSG@18 PS1, Line 18: This change also adds 3 cmake flags (off by default): > Good point about double negative flags. Should we continue to only install the client by default? Are there existing workflows using `make install` that this could break if we start also installing the master and tserver? -- To view, visit http://gerrit.cloudera.org:8080/12847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7 Gerrit-Change-Number: 12847 Gerrit-PatchSet: 1 Gerrit-Owner: Greg Solovyev <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 26 Mar 2019 21:57:55 +0000 Gerrit-HasComments: Yes
