Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12933 )
Change subject: Enable tcmalloc heap sampling by default ...................................................................... Patch Set 1: (1 comment) I vaguely remember this coming up before. Did we previously talk about enabling it by default? http://gerrit.cloudera.org:8080/#/c/12933/1/src/kudu/util/flags.cc File src/kudu/util/flags.cc: http://gerrit.cloudera.org:8080/#/c/12933/1/src/kudu/util/flags.cc@88 PS1, Line 88: DEFINE_int64(heap_sample_every_n_bytes, 524288, Nit: maybe change to 512 * 1024, and below don't bother talking about 524288 but just 512 KB? -- To view, visit http://gerrit.cloudera.org:8080/12933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I99e06bdd04ecde030383709682cf096b5e5191c9 Gerrit-Change-Number: 12933 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mitch Barnett <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 04 Apr 2019 20:08:53 +0000 Gerrit-HasComments: Yes
