Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12933 )
Change subject: Enable tcmalloc heap sampling by default ...................................................................... Enable tcmalloc heap sampling by default This enables tcmalloc heap sampling by default with `--heap-sample-every-n-bytes` set to 512KiB. This will allow users to use the `pprof` tool to gather tcmalloc heap profiles from running Kudu processes, at the cost of some overheard in memory allocation. I've been doing a lot of performance testing on a cluster with heap sampling enabled at this frequency and I don't think the overhead is a problem. Enabling this soon after the release of 1.9 gives us lots of time to run this configuration in tests to see if it causes any problems. Change-Id: I99e06bdd04ecde030383709682cf096b5e5191c9 Reviewed-on: http://gerrit.cloudera.org:8080/12933 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Will Berkeley <[email protected]> --- M src/kudu/util/flags.cc 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Will Berkeley: Verified -- To view, visit http://gerrit.cloudera.org:8080/12933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I99e06bdd04ecde030383709682cf096b5e5191c9 Gerrit-Change-Number: 12933 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mitch Barnett <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]>
