Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12949 )

Change subject: KUDU-2689: Made PartialRow setters use a fluent-style.
......................................................................


Patch Set 1:

Changing a void method to return a value would be source compatible but not 
binary compatible. I am not sure if we have a policy on breaking binary 
compatibility in the client.

If we are concerned about breaking binary compatibility we should probably 
setup a tool to check for breakage between releases.


--
To view, visit http://gerrit.cloudera.org:8080/12949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3476fb3c0a28812e2732e6c6268f31a393928206
Gerrit-Change-Number: 12949
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Brian McDevitt <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Comment-Date: Sat, 06 Apr 2019 21:19:11 +0000
Gerrit-HasComments: No

Reply via email to