Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12949 )
Change subject: KUDU-2689: Made PartialRow setters use a fluent-style. ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/12949/3//COMMIT_MSG Commit Message: PS3: Some of the lines in this commit message are too long. Please wrap lines at 72, 76, or 80 characters (your choice). http://gerrit.cloudera.org:8080/#/c/12949/3//COMMIT_MSG@10 PS3, Line 10: -Changed '@return a PartialRow' to '@return this PartialRow' to clearly indicate that it's the current row that is being mutated rather than a new PartialRow. : -Removed redundant indentation. These two reflect changes made to your original patch in response to code review, right? You don't need to list them here; ultimately this commit message is going to be merged into the source repository as-is and anyone looking at this commit will only see the change it made, not all of its intermediate states in code review. -- To view, visit http://gerrit.cloudera.org:8080/12949 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3476fb3c0a28812e2732e6c6268f31a393928206 Gerrit-Change-Number: 12949 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward <raym...@phdata.io> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Brian McDevitt <br...@phdata.io> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 10 Apr 2019 20:38:34 +0000 Gerrit-HasComments: Yes
