Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12945 )
Change subject: tool: perf tablet_scan action ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12945/1/src/kudu/tools/tool_action_perf.cc File src/kudu/tools/tool_action_perf.cc: http://gerrit.cloudera.org:8080/#/c/12945/1/src/kudu/tools/tool_action_perf.cc@727 PS1, Line 727: MiniTabletServer mts(fs_root, HostPort("127.0.0.1", 0)); : : // Don't bother heartbeating; we didn't start any masters. : mts.options()->master_addresses.clear(); : : RETURN_NOT_OK(mts.Start()); : RETURN_NOT_OK(mts.WaitStarted()); : scoped_refptr<TabletReplica> replica; : RETURN_NOT_OK(mts.server()->tablet_manager()->GetTabletReplica(tablet_id, &replica)); > Do we need the entire tserver? Could we get by just opening the FsManager a I wish that were the case, but I need to bootstrap the tablet in order to scan any data in the WALs. AFAICT that means standing up a TSTabletManager, which means bringing up a full TabletServer. Seems like maybe I could get away with something like what tablet_bootstrap-test or tablet_replica-test do, but it's a lot of setup work. Is there an easier way that I'm missing? -- To view, visit http://gerrit.cloudera.org:8080/12945 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id4667dcb2d9a21d77149ebdae2e29b7fce8b460b Gerrit-Change-Number: 12945 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 08 Apr 2019 00:37:52 +0000 Gerrit-HasComments: Yes
