Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12945 )
Change subject: tool: perf tablet_scan action ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12945/1/src/kudu/tools/tool_action_perf.cc File src/kudu/tools/tool_action_perf.cc: http://gerrit.cloudera.org:8080/#/c/12945/1/src/kudu/tools/tool_action_perf.cc@727 PS1, Line 727: MiniTabletServer mts(fs_root, HostPort("127.0.0.1", 0)); : : // Don't bother heartbeating; we didn't start any masters. : mts.options()->master_addresses.clear(); : : RETURN_NOT_OK(mts.Start()); : RETURN_NOT_OK(mts.WaitStarted()); : scoped_refptr<TabletReplica> replica; : RETURN_NOT_OK(mts.server()->tablet_manager()->GetTabletReplica(tablet_id, &replica)); > I wish that were the case, but I need to bootstrap the tablet in order to s Yeah, I don't think there's an easier path, though the setup doesn't seem too complex (hopefully no surprises though). I would be weary of committing this since it seems like it'd only really useful for mini-clusters, and it might be confusing to have it around as a documented tool if that's the case. If you think it's not worth the fuss, this could just remain a "useful but not worth the polish so it sits in gerrit" tool. -- To view, visit http://gerrit.cloudera.org:8080/12945 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id4667dcb2d9a21d77149ebdae2e29b7fce8b460b Gerrit-Change-Number: 12945 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 08 Apr 2019 05:48:55 +0000 Gerrit-HasComments: Yes
