Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12969 )
Change subject: Created 'Adding tablet server best practices' per KUDU-2449. ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/12969/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12969/2//COMMIT_MSG@7 PS2, Line 7: Created 'Adding tablet server best practices' per KUDU-2449. We prefix a commit summary as such when it directly addresses a JIRA. So you should reformat as: KUDU-2449: ... http://gerrit.cloudera.org:8080/#/c/12969/2//COMMIT_MSG@9 PS2, Line 9: This section will detail the best practices around adding Nit: the wrapping here seems unnecessarily aggressive. You could wrap at 72, 76, or 80 characters. But if this is your preferred style then don't worry about it. http://gerrit.cloudera.org:8080/#/c/12969/2/docs/administration.adoc File docs/administration.adoc: PS2: Could you provide a rendered version of this page? I think GitHub will render asciidoc, so pushing (and linking) to a GH branch should be good enough. -- To view, visit http://gerrit.cloudera.org:8080/12969 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e44b4a84a8ca8048b8dc930cc1ee228daef6cf9 Gerrit-Change-Number: 12969 Gerrit-PatchSet: 2 Gerrit-Owner: Mitch Barnett <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 09 Apr 2019 19:28:46 +0000 Gerrit-HasComments: Yes
