Mitch Barnett has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12969 )

Change subject: KUDU-2449: "Tablet server addition" best practices
......................................................................


Patch Set 3:

(3 comments)

> Patch Set 2:
>
> (3 comments)

http://gerrit.cloudera.org:8080/#/c/12969/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12969/2//COMMIT_MSG@7
PS2, Line 7: KUDU-2449: "Tablet server addition" best practices
> We prefix a commit summary as such when it directly addresses a JIRA. So yo
Done


http://gerrit.cloudera.org:8080/#/c/12969/2//COMMIT_MSG@9
PS2, Line 9: This section will detail the best practices around adding new 
tablet
> Nit: the wrapping here seems unnecessarily aggressive. You could wrap at 72
Done


http://gerrit.cloudera.org:8080/#/c/12969/2/docs/administration.adoc
File docs/administration.adoc:

PS2:
> Could you provide a rendered version of this page? I think GitHub will rend
https://github.infra.cloudera.com/mbarnett/adoc_test/blob/master/administration.adoc



--
To view, visit http://gerrit.cloudera.org:8080/12969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e44b4a84a8ca8048b8dc930cc1ee228daef6cf9
Gerrit-Change-Number: 12969
Gerrit-PatchSet: 3
Gerrit-Owner: Mitch Barnett <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
Gerrit-Comment-Date: Tue, 09 Apr 2019 21:47:46 +0000
Gerrit-HasComments: Yes

Reply via email to