Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12976 )
Change subject: tool: fixes for kudu local_replica dump rowset ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12976/2/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/12976/2/src/kudu/tools/kudu-tool-test.cc@1978 PS2, Line 1978: switch (i) { : case 0: exp_val = 1; break; : case 1: exp_val = 9; break; : case 2: exp_val = 5; break; : default: LOG(FATAL) << "Unreachable code"; : } > Mind adding a comment explaining the significance of these values? I know i I rejiggered the test to cover the case where nrows causes us to print partial rowsets. That uncovered a bug in how I was inserting rows, and after fixing that, the values here went back to being static again. http://gerrit.cloudera.org:8080/#/c/12976/2/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/12976/2/src/kudu/tools/tool_action_local_replica.cc@685 PS2, Line 685: != -1 > This should probably be >= 0 to match L679, in which case the default seman Done -- To view, visit http://gerrit.cloudera.org:8080/12976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib50ab4e7b2aa0fec60ce0718d16823945a05cb7f Gerrit-Change-Number: 12976 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 10 Apr 2019 03:47:05 +0000 Gerrit-HasComments: Yes
